Dedup UnboundedChannel and UnboundedPriorityChannel #101396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future.
|
Tagging subscribers to this area: @dotnet/area-system-threading-channels |
stephentoub
commented
Apr 22, 2024
src/libraries/System.Threading.Channels/src/System/Threading/Channels/UnboundedChannel.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 22, 2024
adamsitnik
approved these changes
Apr 23, 2024
src/libraries/System.Threading.Channels/src/System/Threading/Channels/Channel.netcoreapp.cs
Show resolved
Hide resolved
src/libraries/System.Threading.Channels/src/System/Threading/Channels/IDebugEnumerator.cs
Show resolved
Hide resolved
src/libraries/System.Threading.Channels/src/System/Threading/Channels/Channel.netcoreapp.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.Channels/src/System/Threading/Channels/Channel.netcoreapp.cs
Show resolved
Hide resolved
src/libraries/System.Threading.Channels/src/System/Threading/Channels/UnboundedChannel.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.Channels/src/System/Threading/Channels/UnboundedChannel.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 23, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Dedup UnboundedChannel and UnboundedPriorityChannel We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future. * Address PR feedback
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
* Dedup UnboundedChannel and UnboundedPriorityChannel We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future. * Address PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future.